Parse error messages from scheduling failures #5390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baierjan
force-pushed
the
fail_on_schedule_failure
branch
from
1cde6cb
to
19da83c
Compare
|
The change looks generally good. However, it seems it broke the developer mode and the fullstack test. Both tests are very similar so that failures are likely related. Maybe they rely on being able to schedule jobs at all despite those errors? |
openqa-cli schedule will only fail if there is error key in the json root. In our case, the error message is inside the failed job list. Make openqa-cli fail on that as well. Reference: https://progress.opensuse.org/issues/138203
baierjan
force-pushed
the
fail_on_schedule_failure
branch
from
19da83c
to
b23bd17
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5390 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 389 389
Lines 37530 37530
=======================================
Hits 36918 36918
Misses 612 612 ☔ View full report in Codecov by Sentry. |
|
And the test failures are gone... |
Martchus
approved these changes
Dec 8, 2023
okurz
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openqa-cli schedule will only fail if there is error key in the json
root. In our case, the error message is inside the failed job list. Make
openqa-cli fail on that as well.
Reference: https://progress.opensuse.org/issues/138203