Handle no job group filter matches gracefully #5411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This is a followup for #5388 and #5401. When there were no matches for job group globs, no query condition would be generated previously. Giving the false impression that all job groups were matching. So now we just generate an impossible query that cannot match anything with the group id `0`. Progress: https://progress.opensuse.org/issues/134933
kraih
force-pushed
the
k/group_filters_no_match
branch
from
fe218a4
to
220ada2
Compare
kraih
changed the title
kalikiana
approved these changes
Dec 22, 2023
perlpunk
approved these changes
Dec 22, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5411 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 389 389
Lines 37633 37644 +11
=======================================
+ Hits 37021 37032 +11
Misses 612 612 ☔ View full report in Codecov by Sentry. |
okurz
reviewed
Dec 22, 2023
Comment on lines
+722
to
724
| return [0] unless my $groups = $self->groups_for_globs; | ||
| return [map { $_->id } @$groups] if @$groups; | ||
|
|
There was a problem hiding this comment.
looks even cleaner than before, nice! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup for #5388 and #5401. When there were no matches for job group globs, no query condition would be generated previously. Giving the false impression that all job groups were matching. So now we just generate an impossible query that cannot match anything with the group id
0.Progress: https://progress.opensuse.org/issues/134933