Improve UI for comments filter #5427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
reviewed
Jan 16, 2024
* Avoid many `else if` cases that can easily be combined * Use more modern JavaScript coding style * Reduce code duplication
Martchus
force-pushed
the
comment-search
branch
from
26d27a1
to
2f6b7e0
Compare
okurz
approved these changes
Jan 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5427 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 389 389
Lines 37728 37728
=======================================
Hits 37116 37116
Misses 612 612 ☔ View full report in Codecov by Sentry. |
kalikiana
reviewed
Jan 17, 2024
kalikiana
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See particular commit messages and https://progress.opensuse.org/issues/151402#note-9