Apply perlcritic rule for useless interpolation of literal string #5448
Conversation
b10n1k
force-pushed
the
perlcritic_quote_rule
branch
from
bdc2b97
to
f53cf4b
Compare
lib/OpenQA/Client/Archive.pm
Outdated
| @@ -193,7 +193,7 @@ sub _progress_monitior ($ua, $tx) { | |||
| $last_updated = time; | |||
| if ($progress < $current) { | |||
| $progress = $current; | |||
| print("\rDownloading $filename: ", $size == $len ? 100 : $progress . "%"); | |||
| print('\rDownloading $filename: ', $size == $len ? 100 : $progress . '%'); | |||
There was a problem hiding this comment.
This should be left unchanged.
b10n1k
force-pushed
the
perlcritic_quote_rule
branch
from
f53cf4b
to
5e1388a
Compare
b10n1k
force-pushed
the
perlcritic_quote_rule
branch
from
5e1388a
to
a63f08e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5448 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 389 389
Lines 37744 37744
=======================================
Hits 37132 37132
Misses 612 612 ☔ View full report in Codecov by Sentry. |
What should i do about those? |
|
I guess we can make an exception for "92.63% of diff hit (target 100.00%)" here. The changed lines look simple enough. |
This comment was marked as resolved.
This comment was marked as resolved.
|
handling the conflict resolution and merge manually |
This is propably the biggest load of files which should adapt to the rule which force single quotes when string doesnt need interpolation. Includes also some minor changes for *Hash key with quotes* but not all of them. https://progress.opensuse.org/issues/138416 Signed-off-by: ybonatakis <ybonatakis@suse.com>
okurz
force-pushed
the
perlcritic_quote_rule
branch
from
199dd6b
to
52eb046
Compare
This is propably the biggest load of files which should adapt to the rule which force single quotes when string doesnt need interpolation.
Includes also some minor changes for Hash key with quotes but not all of them.
https://progress.opensuse.org/issues/138416