Refactor methods which violate the deeply nested loops #5450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b10n1k
force-pushed
the
perlcritic_deeply_nested
branch
from
39dabbf
to
3804cf2
Compare
Martchus
requested changes
Feb 3, 2024
b10n1k
force-pushed
the
perlcritic_deeply_nested
branch
2 times, most recently
from
19d26cd
to
8ccc0bc
Compare
Martchus
requested changes
Feb 5, 2024
b10n1k
force-pushed
the
perlcritic_deeply_nested
branch
2 times, most recently
from
545957e
to
b767891
Compare
okurz
reviewed
Feb 5, 2024
Comment on lines
102
to
105
| for my $worker (keys %taken) { | ||
| my $ji = $taken{$worker}; | ||
| if ($prio > 0) { | ||
| # this means we will by default increase the offset per half-assigned job, | ||
| # so if we miss 1/25 jobs, we'll bump by +24 | ||
| log_debug "Discarding job $ji->{id} (with priority $prio) due to incomplete parallel cluster" | ||
| . ', reducing priority by ' | ||
| . STARVATION_PROTECTION_PRIORITY_OFFSET; | ||
| $j->{priority_offset} += STARVATION_PROTECTION_PRIORITY_OFFSET; | ||
| } | ||
| else { | ||
| # don't "take" the worker, but make sure it's not | ||
| # used for another job and stays around | ||
| log_debug "Holding worker $worker for job $ji->{id} to avoid starvation"; | ||
| $allocated_workers->{$worker} = $ji->{id}; | ||
| } | ||
|
|
||
| _allocate_worker_with_priority($prio, $ji, $j, $allocated_workers, $worker); | ||
| } |
There was a problem hiding this comment.
Now maybe we can go one step further
_allocate_worker_with_priority($prio, $taken{$_}, $j, $allocated_workers, $_) for keys %taken;There was a problem hiding this comment.
no sure. I see $ji in use below in the code
Martchus
approved these changes
Feb 5, 2024
|
It would be useful to introduce changes step by step and rerun the failing test, to see which change is the culprit. |
perlpunk
reviewed
Feb 6, 2024
b10n1k
force-pushed
the
perlcritic_deeply_nested
branch
2 times, most recently
from
e9210ed
to
800d73b
Compare
|
still failed tidy. Please tidy and consider to mark your PR as ready for review |
Simply extract parts of the subroutines which causes perlcritic to complain about deeply nested loops. https://progress.opensuse.org/issues/138416 Signed-off-by: ybonatakis <ybonatakis@suse.com>
b10n1k
force-pushed
the
perlcritic_deeply_nested
branch
from
800d73b
to
de41fba
Compare
Martchus
approved these changes
Feb 6, 2024
Martchus
approved these changes
Feb 6, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5450 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 389 389
Lines 37751 37769 +18
=======================================
+ Hits 37139 37157 +18
Misses 612 612 ☔ View full report in Codecov by Sentry. |
perlpunk
approved these changes
Feb 6, 2024
okurz
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply extract parts of the subroutines which causes perlcritic to complain about deeply nested loops.
https://progress.opensuse.org/issues/138416