Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary disabling of strict refs #5453

Merged
merged 1 commit into from Feb 6, 2024
Merged

Remove unnecessary disabling of strict refs #5453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions lib/OpenQA/Parser.pm
View file
Open in desktop
Expand Up @@ -40,7 +40,6 @@ sub _build_parser {
if (my $e = load_class $parser_name) {
croak ref $e ? "Exception: $e" : 'Parser not found!';
}
no strict 'refs';
eval { $p_instance = $parser_name->new(@args); };
croak "Invalid parser supplied: $@" if $@;
}
Expand Down Expand Up @@ -136,7 +135,6 @@ sub restore_el {
my $data = $obj->{OpenQA::Parser::DATA_FIELD()};

{
no strict 'refs';
return $type->can('new') ? $type->new(ref $data eq 'ARRAY' ? @{$data} : $data) : $data;
};
}
Expand Down Expand Up @@ -168,7 +166,6 @@ sub _load_tree {
my @coll = sort keys %{$tree};

{
no strict 'refs';
local $@;
eval {
foreach my $collection (@coll) {
Expand Down