git subrepo pull (merge) external/os-autoinst-common

external/os-autoinst-common/.github/workflows/perl-critic.yml

@@ -1,11 +1,7 @@
 ---
 name: 'Perl critic'
 
-on:
-  pull_request:
-  push:
-    branches:
-      - 'master'
+on: [push, pull_request]
 
 jobs:
   perl-critic-checks:

external/os-autoinst-common/.github/workflows/perl-lint-checks.yml

@@ -1,18 +1,14 @@
 ---
 name: 'Perl static checks'
 
-on:
-  pull_request:
-  push:
-    branches:
-      - 'master'
+on: [push, pull_request]
 
 jobs:
   perl-lint-checks:
     runs-on: ubuntu-latest
     name: "Perltidy"
     container:
-      image: perldocker/perl-tester
+      image: registry.opensuse.org/devel/openqa/containers/os-autoinst_dev
     steps:
       - uses: actions/checkout@v4
       - run: GITHUB_ACTIONS=1 ./tools/tidyall --check-only --all --quiet

external/os-autoinst-common/.github/workflows/yamllint.yml

@@ -1,11 +1,7 @@
 ---
 name: 'YAML-lint'
 
-on:
-  pull_request:
-  push:
-    branches:
-      - 'master'
+on: [push, pull_request]
 
 jobs:
   yaml-lint:

external/os-autoinst-common/.gitrepo

@@ -6,7 +6,7 @@
 [subrepo]
 	remote = git@github.com:os-autoinst/os-autoinst-common.git
 	branch = master
-	commit = fbd66e7f61d2397f55bc8b6143a405c8ed639008
-	parent = dc3c200d28283b7a117182b837546ce3f598e8f3
+	commit = e167bdf2bccb043d658da0cda7e63472ef6bff85
+	parent = da302936978e4d59020d8463bdd2b16d4f241c17
 	method = merge
 	cmdver = 0.4.6

external/os-autoinst-common/.mergify.yml

@@ -7,6 +7,9 @@ pull_request_rules:
       - "#review-requested=0"
       - -label~=^acceptance-tests-needed|not-ready
       - base=master
+      - "#check-failure=0"
+      - "#check-pending=0"
+      - linear-history
     actions:
       merge:
         method: merge

external/os-autoinst-common/Makefile

@@ -0,0 +1,4 @@
+.PHONY: update-deps
+update-deps:
+	tools/update-deps --cpanfile cpanfile
+

external/os-autoinst-common/dependencies.yaml

@@ -15,7 +15,6 @@ main_requires:
   # Needed until preaction/Log-Any#105 is solved.
   perl(Storable): '>= 3.06'
   perl(Module::CPANfile):
-  perl(version):
 
 develop_requires:
   perl(Perl::Tidy): '== 20230912'

external/os-autoinst-common/lib/perlcritic/Perl/Critic/Policy/HashKeyQuotes.pm

@@ -14,20 +14,22 @@ our $VERSION = '0.0.1';
 
 sub default_severity { return $SEVERITY_HIGH }
 sub default_themes { return qw(openqa) }
+# we only want the check quoted expressions
 sub applies_to { return qw(PPI::Token::Quote::Single PPI::Token::Quote::Double) }
 
 # check that hashes are not overly using quotes
 # (os-autoinst coding style)
 sub violates ($self, $elem, $document) {
-    #we only want the check hash keys
-    return if !is_hash_key($elem);
+    # skip anything that's not a hash key
+    return () unless is_hash_key($elem);
 
-    my $c = $elem->content;
-    # special characters
-    return if $c =~ m/[- \/<>.=_:\\\$\|]/;
+    my $k = $elem->literal;
+    # skip anything that has a special symbol in the content
+    return () unless $k =~ m/^\w+$/;
 
+    # report violation
     my $desc = q{Hash key with quotes};
-    my $expl = q{Avoid useless quotes};
+    my $expl = qq{Avoid useless quotes for key "$k"};
     return $self->violation($desc, $expl, $elem);
 }