Ensure all hidden form fields in test overview filter

[perlpunk]

Issue: https://progress.opensuse.org/issues/154537

The code was skipping elements that already existed in the form, and this resulted in elements with multiple values to only keep one value. Now the elements to be added are collected and only added to the form after the loop.

Bug was introduced in 2f6b7e0

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (199e451) 98.38% compared to head (1471ceb) 98.38%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5464   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         389      389           
  Lines       37829    37832    +3     
=======================================
+ Hits        37217    37220    +3     
  Misses        612      612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Martchus]

I would avoid the repeated calls to $('#filter-form') in the loop and stick to standard JavaScript (as we probably shouldn't introduce more jQuery code at this point):

Suggested change

	for (var i = 0; i < hiddenInputs.length; i++) {
	$('#filter-form').append(hiddenInputs[i]);
	}
	const filterForm = document.getElementById('filter-form');
	hiddenInputs.forEach(i => filterForm.appendChild(i));

Probably the code that creates the input elements should also just use document.createElement('input') and normal DOM APIs.

It is not obvious at all why your change makes a difference but it is because of what the code passed via paramHandler does. That means you could probably also just change that code and make it skip those elements, e.g. replace if (formElement) { with if (formElement && !formElement.hidden) {. This would avoid an extra array and loop.

[perlpunk]

I tried now:

if (formElement && !formElement.hidden)

but then it is always skipping the last distri mentioned in the query parameters...
I need to debug this.

[perlpunk]

So apparently in the first call of the paramHandler form[key] is undefined. In the second it''s returning HTMLInputElement (hidden). After that it returns a RadioNodeList. Possibly because there are now two elements already. Not sure yet how I should handle that.

[perlpunk]

Also I would like to add that I didn't introduce any new jquery code. I just moved it from one loop to the other.

[Martchus]

Ok, then your approach might be simpler after all. And it is true that the code was just moved.