Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump codemirror from 4.13.0 to 5.58.2 #5469

Merged
merged 1 commit into from Feb 14, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 13, 2024

Bumps codemirror from 4.13.0 to 5.58.2.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 13, 2024
@okurz
Copy link
Member

okurz commented Feb 13, 2024

Wow, that was quick :D

@Martchus
Copy link
Contributor

This is a major version upgrade. I'd only merge it after verifying locally that everything still looks as expected. (And I'm only about to update the packaging. That's why these packaging checks are still bound to fail.)

@okurz
Copy link
Member

okurz commented Feb 13, 2024

Sure. But actually I would trust the CI checks as they include actual openQA-in-openQA tests :)

@okurz
Copy link
Member

okurz commented Feb 14, 2024

Sure. But actually I would trust the CI checks as they include actual openQA-in-openQA tests :)

Actually we don't have such tests. We do not actually have openQA-in-openQA tests for openQA pull requests. I must have remembered something really wrong here.

@kalikiana
Copy link
Member

@Mergifyio rebase

Bumps [codemirror](https://github.com/codemirror/basic-setup) from 4.13.0 to 5.58.2.
- [Changelog](https://github.com/codemirror/basic-setup/blob/main/CHANGELOG.md)
- [Commits](https://github.com/codemirror/basic-setup/commits)

---
updated-dependencies:
- dependency-name: codemirror
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Copy link
Contributor

mergify bot commented Feb 14, 2024

rebase

✅ Branch has been successfully rebased

@kalikiana kalikiana force-pushed the dependabot/npm_and_yarn/codemirror-5.58.2 branch from 1db6498 to 3942e53 Compare February 14, 2024 11:25
Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally. The source view and the job template editor still look good and those are the only relevant places when I remember correctly.

@mergify mergify bot merged commit 9c8360a into master Feb 14, 2024
47 checks passed
@mergify mergify bot deleted the dependabot/npm_and_yarn/codemirror-5.58.2 branch February 14, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants