Add test for Minion dashboard #5571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlpunk
approved these changes
Apr 10, 2024
kalikiana
approved these changes
Apr 10, 2024
|
Considering the test failure we maybe need to merge #5572 first. |
|
@Mergifyio rebase |
* Use our current coding style for quoting * Avoid useless comments
Just check whether the dashboard is accessible from the menu and do a small smoke test. This should already catch issues caused by severe JavaScript errors like https://progress.opensuse.org/issues/158805.
✅ Branch has been successfully rebased |
okurz
approved these changes
Apr 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5571 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 392 392
Lines 38234 38244 +10
=======================================
+ Hits 37621 37631 +10
Misses 613 613 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just check whether the dashboard is accessible from the menu and do a small
smoke test. This should already catch issues caused by severe JavaScript
errors like https://progress.opensuse.org/issues/158805.