Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recording how to run openQA test in 5 minutes #5611

Merged
merged 4 commits into from May 7, 2024

Conversation

baierjan
Copy link
Member

@baierjan baierjan commented May 2, 2024

Add scenario for asciinema recording and include it into documentation.

Add Dockerfile and a short Makefile to allow generating GIFs out of autocast yaml files with the asciicast + agg combo without installing anything. The cast will be done inside the container as well, so the recording is done isolated from the rest of the system.

Reference: https://progress.opensuse.org/issues/76978

Copy link

github-actions bot commented May 2, 2024

Great PR! Please pay attention to the following items before merging:

Files matching docs/*.asciidoc:

  • Consider generating documentation locally to verify it is rendered correctly using tools/generate-docs

This is an automatically generated QA checklist based on modified files.

Copy link
Member

@kalikiana kalikiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat

Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding 5.5 MiB of binary data to our repo's master branch is maybe not so nice. It would be nice if we could offload the binary to the gh-pages branch (which has a completely separate chain of commits).

(I'm only requesting changes here so we have at least some time to discuss this. If you all think having 5.5 MiB on the master branch is ok then just dismiss my review. Otherwise the change looks good to merge.)

@baierjan
Copy link
Member Author

baierjan commented May 4, 2024

Adding 5.5 MiB of binary data to our repo's master branch is maybe not so nice. It would be nice if we could offload the binary to the gh-pages branch (which has a completely separate chain of commits).

(I'm only requesting changes here so we have at least some time to discuss this. If you all think having 5.5 MiB on the master branch is ok then just dismiss my review. Otherwise the change looks good to merge.)

Yes, that is actually a very good point. Having a (rather large) gif file is more portable, but it makes the repo and also the page (which then loads a little bit slower). I was also thinking about using the .cast file and embed the asciicast javascript player into the documentation, but that would on the other hand introduce external dependency.

As we might be adding more of this later, we might want to have the optimal way to handle it. Do we have any convenient way how to use the gh-pages branch? I mean I can easily push the recording there but it would be then a little bit awkward to keep track if the version there is "in-sync" with the source in the main branch.

Add Dockerfile and a short Makefile to allow generating GIFs out of
autocast yaml files with the asciicast + agg combo without installing
anything. The cast will be done inside the container as well, so the
recording is done isolated from the rest of the system.
@baierjan
Copy link
Member Author

baierjan commented May 6, 2024

I created #5616 which should include the recording directly into pages. The GIF is removed from this pull request and instead a gitignore is introduced to not accidentally push the recordings here. Will that work for you @Martchus ?

@mergify mergify bot merged commit aaa122b into master May 7, 2024
47 checks passed
@mergify mergify bot deleted the openqa-in-5-minutes branch May 7, 2024 07:28
@@ -0,0 +1,102 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where can I find a documentation of this file format? I searched https://docs.asciinema.org/ but could not find anything

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This yaml file is for https://github.com/k9withabone/autocast. The tool is briefly mentioned in the commit message (yes, it does not look like it). This makefile rule will then create a cast from it

%.cast:%.yaml
autocast --overwrite $< $@

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is where I was able to find it initially: https://docs.asciinema.org/integrations/?h=autocast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants