Adjust bootstrap to 5.x #5621
Closed
Adjust bootstrap to 5.x #5621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://progress.opensuse.org/issues/159408 I'm guessing |
|
Alternative to #5514? In the Unblock the q came up if we can't re-use the existing PR |
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
I'll resolve conflicts and try to continue here. |
Martchus
force-pushed
the
159171
branch
3 times, most recently
from
d2ebae3
to
88f8f15
Compare
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Remove asset files not in current version and adjust certain usages as per documentation. Related ticket: https://progress.opensuse.org/issues/159408 Signed-off-by: ybonatakis <ybonatakis@suse.com>
Related ticket: https://progress.opensuse.org/issues/159408 Signed-off-by: ybonatakis <ybonatakis@suse.com>
* Fix generally invalid HTML * Use regular JavaScript APIs as shown in the Bootstrap 5 documentation instead of jQuery APIs when it was not too much extra effort * Disable smooth scrolling in unit tests as it disturbs our tests (because elements are then no longer immediately in the view port and thus not immediately clickable - and even if it worked we want our tests to be as fast as possible) * Remove the remains of the Litera theme completely as those definitions didn't seem to do much anymore anyway * Adapt usage of Bootstrap APIs where necessary and also tests where necessary * Workaround UTF-8 byte order mark being added by AssetPack in the middle of the CSS document in production mode (which is not a new problem but has apparently a more severe impact with Bootstap 5) Related ticket: https://progress.opensuse.org/issues/159408
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove asset files not in current version and adjust some CSS variables as per documentation.