Add GRU task to update DISTRI and NEEDLES_DIR from git if needed

[asdil12]

Ticket: https://progress.opensuse.org/issues/159171

[asdil12]

Still lacking tests (manually tested at least for the codepath via OpenQA/WebAPI/Controller/API/V1/Job.pm).

[okurz]

@asdil12 you push changes but I don't know what they cover. Could you please write an update to state what your latest changes include?

[asdil12]

last push was the redundant config name.

[Martchus]

It generally looks good to merge now.

[okurz]

There are still multiple unresolved suggestions, in particular about the die-messages

[asdil12]

There are still multiple unresolved suggestions, in particular about the die-messages

Not sure what you mean - all discussions are resolved.
If you think, anything is not resolved, please unresolve the according discussion.

I had a look at the die messages and they all look fine.

I checked that all suggestions were taken into account

[Martchus]

@asdil12 Looks like one of the tests is failing:

[12:16:50] t/14-grutasks.t ....... 30/? DBIx::Class::SQLMaker::ClassicExtensions::belch(): Warning: HASH ref as bind value in insert is not supported at /home/squamata/project/lib/OpenQA/Shared/Plugin/Gru.pm line 127
    # No tests run!

#   Failed test 'No tests run for subtest "handling failing GRU task"'
#   at t/14-grutasks.t line 584.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (dc3ed1b) to head (a38165b).
Report is 4 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #5622    +/-   ##
========================================
  Coverage   98.40%   98.41%            
========================================
  Files         393      394     +1     
  Lines       38319    38438   +119     
========================================
+ Hits        37709    37828   +119     
  Misses        610      610            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kalikiana]

[13:50:56] t/full-stack.t ......... 33/?     # Unexpected Javascript console errors: [
    #   {
    #     level     => "SEVERE",
    #     message   => "http://localhost:9526/tests/Unable%20to%20read%20image:%20Can't%20open%20file%20%22/tmp/webui.worker-1.egZpq4BW/%22:%20No%20such%20file%20or%20directory%20at%20/home/squamata/project/lib/OpenQA/WebAPI/Controller/Running.pm%20line%20211. - Failed to load resource: the server responded with a status of 404 (Not Found)",
    #     source    => "network",
    #     timestamp => 1716558871922,
    #   },
    # ]
    # full result panel contents:
    # State: running, started less than a minute ago 
    #   
    # Scheduled product: job has not been created by posting an ISO
    # Assigned worker: 26686ca7dff7:1

    #   Failed test 'Expected result not found'
    #   at /home/squamata/project/t/lib/OpenQA/Test/FullstackUtils.pm line 76.

    #   Failed test 'job 8 is incomplete'
    #   at t/full-stack.t line 418.
    # 0

    #   Failed test 'reason for incomplete specified'
    #   at t/full-stack.t line 419.
    #                   'State: running, started less than a minute ago 
    #   
    # Scheduled product: job has not been created by posting an ISO
    # Assigned worker: 26686ca7dff7:1'
    #     doesn't match '(?^u:Failed to download.*non-existent.qcow2)'
[...]
#   Failed test 'Cache tests'
#   at t/full-stack.t line 442.
findElement: no such element: Unable to locate element: {"method":"css selector","selector":".embedded-logfile"} 

[kalikiana]

Fullstack passed after a retry 🤔

codecov is still/again listing various gaps:

lib/OpenQA/Task/Git/Clone.pm#L24-L26
lib/OpenQA/Task/Git/Clone.pm#L29-L34
lib/OpenQA/Task/Git/Clone.pm#L37-L38
lib/OpenQA/Task/Git/Clone.pm#L41-L44
lib/OpenQA/Task/Git/Clone.pm#L48-L51
lib/OpenQA/Task/Git/Clone.pm#L54-L55
lib/OpenQA/Task/Git/Clone.pm#L58-L59
lib/OpenQA/Task/Git/Clone.pm#L61-L62
lib/OpenQA/Task/Git/Clone.pm#L65-L67
lib/OpenQA/Task/Git/Clone.pm#L70-L73
lib/OpenQA/Task/Git/Clone.pm#L76-L78
lib/OpenQA/Task/Git/Clone.pm#L81-L83
lib/OpenQA/Task/Git/Clone.pm#L86-L94
lib/OpenQA/Task/Git/Clone.pm#L96-L97
lib/OpenQA/Task/Git/Clone.pm#L99
lib/OpenQA/Task/Git/Clone.pm#L103-L106
lib/OpenQA/Task/Git/Clone.pm#L109-L110
lib/OpenQA/Task/Git/Clone.pm#L112-L113
lib/OpenQA/Task/Git/Clone.pm#L117
lib/OpenQA/Utils.pm#L613-L614