Allow specifying multiple comma-separated values for CORS header #5626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Access-Control-Allow-Origin` only allows specifying one concrete origin or the wildcard `*`. So in order to support multiple allowed origins we must split the header value server-side and return the header value that matches the requests origin (if allowed). This is also what is suggested in the last paragraph of https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Origin#examples. This change also only appends the additional value of the Vary header (which is set in accordance with https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Origin#cors_and_caching) to avoid completely overriding it (e.g. preserving the Mojolicious default). I tested this locally configuring multiple or just one allowed origins and verifying via the developer tools that the headers are returned correctly. Related ticket: https://progress.opensuse.org/issues/159384
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5626 +/- ##
=========================================
Coverage ? 98.40%
=========================================
Files ? 393
Lines ? 38317
Branches ? 0
=========================================
Hits ? 37707
Misses ? 610
Partials ? 0 ☔ View full report in Codecov by Sentry. |
okurz
approved these changes
May 8, 2024
perlpunk
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Access-Control-Allow-Originonly allows specifying one concrete origin or the wildcard*. So in order to support multiple allowed origins we must split the header value server-side and return the header value that matches the requests origin (if allowed). This is also what is suggested in the last paragraph ofhttps://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Origin#examples.
This change also only appends the additional value of the Vary header (which is set in accordance with
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Origin#cors_and_caching) to avoid completely overriding it (e.g. preserving the Mojolicious default).
I tested this locally configuring multiple or just one allowed origins and verifying via the developer tools that the headers are returned correctly.
Related ticket: https://progress.opensuse.org/issues/159384