-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare SUT package versions in investigation, if available #5643
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
With this, the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5643 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 393 393
Lines 38318 38319 +1
=======================================
+ Hits 37708 37709 +1
Misses 610 610 ☔ View full report in Codecov by Sentry. |
I would have expected the file to show up there. You have already added it to the relevant list of files and I wouldn't know where to add it additionally. We also won't seem to actually use |
I guess I was looking at not patched version, now it does show up. And BTW, here is how the feature works: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note some minor points on the phrasing. Otherwise looks good
Thanks, updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I wasn't considering that sut packages can be used just the same. You found a pretty clean way to do that without needing to have any SUT/OS specific implementations, great!
Looks like codecov status isn't reported (that's why it didn't got merged yet) |
yeah, codecov isn't always that stable. https://app.circleci.com/pipelines/github/os-autoinst/openQA/13581/workflows/cb0894d1-7d56-4d0c-a8e4-b5afac1b43c1/jobs/127466 shows an error regarding github rate limit although we use a token. Let's rebase with the help of mergify and give the CI pipeline another try |
@Mergifyio rebase |
In addition to showing diff of worker_packages.txt, include also a diff of sut_packages.txt. Creating the file is up to the test, but do add it to list of files uploaded at the job end. Document how to use this feature. And while at it, document also `worker_packages.txt` and `PACKAGES_CMD` setting.
✅ Branch has been successfully rebased |
commit fcb740d Merge: 049c328 4d80c34 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> AuthorDate: Sun May 19 11:48:35 2024 +0000 Commit: GitHub <noreply@github.com> CommitDate: Sun May 19 11:48:35 2024 +0000 Merge pull request os-autoinst#5643 from marmarek/sut-packages Compare SUT package versions in investigation, if available
In addition to showing diff of worker_packages.txt, include also a diff
of sut_packages.txt. Creating the file is up to the test, but do add it
to list of files uploaded at the job end.
Document how to use this feature. And while at it, document also
worker_packages.txt
andPACKAGES_CMD
setting.