Prevent git_clone to interfere with needle tasks #5862
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5862 +/- ##
=======================================
Coverage 98.51% 98.51%
=======================================
Files 394 394
Lines 38730 38737 +7
=======================================
+ Hits 38153 38160 +7
Misses 577 577 ☔ View full report in Codecov by Sentry. |
okurz
reviewed
Aug 16, 2024
lib/OpenQA/Task/Git/Clone.pm
Outdated
| my $retry_delay = {delay => 30 + int(rand(10))}; | ||
| # Don't interfere with any needle task | ||
| return $job->retry($retry_delay) |
There was a problem hiding this comment.
Each needle task shouldn't take that long. I would use much shorter delays here. How about 3s?
There was a problem hiding this comment.
The delete_needles task can take longer I guess. But I reduced it to 5s now.
kalikiana
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://progress.opensuse.org/issues/164883