allow tests to download specific test data #68
Conversation
|
|
||
| $self->app->log->debug("serving data for job ".$self->{job}->{id}); | ||
|
|
||
| my $distri = $self->{job}->{settings}->{DISTRI}; | ||
|
|
||
| return sprintf "%s/os-autoinst/tests/%s/data/", $openqa::basedir, $distri; |
There was a problem hiding this comment.
For remote workers I created /var/lib/openqa/share/tests. Then /var/lib/os-autoinst/tests is symlink to this directory. Can't tests be more of a part of openqa than os-autoinst? (For future reference, until my PRs are ready)
There was a problem hiding this comment.
The tests are actually different between distributions and so they are part of nothing, but in the sense of things we need the distributions somewhere, where doesn't really matter. But they used to live in os-autoinst, openQA is "just" the UI.
There was a problem hiding this comment.
the benefit of this PR is that the tests don't hardcode the location any longer, but rely on openQA to know where the data is. openQA needs to continue to have all the distributions checked out, so if you change the location for the tests, you only have to change File.pm
|
is anyone reviewing? |
|
LGTM |
allow tests to download specific test data
issue 4658