Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web UI controls to select 20/50/100/400 previous results #744

Merged
merged 1 commit into from Jul 7, 2016

Conversation

okurz
Copy link
Member

@okurz okurz commented Jun 14, 2016

The query parameter 'limit_previous' allows to show more than the default 10
previous results on demand for some time. The current commit adds web UI
selections below the table of the previous build to reload the same page with
higher number of previous results on demand.

Example screenshot:
openqa_limit_previous_results_gui_100percent_padded

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 81a5023 on okurz:feature/limit_previous_builds_gui into * on os-autoinst:master*.

@coolo
Copy link
Contributor

coolo commented Jun 14, 2016

replace the join('/') with join( ' / ') and it would look better IMO - it's a bit crowded

@okurz
Copy link
Member Author

okurz commented Jun 14, 2016

Well, I knowingly selected this way to write. Let's see if I find some "language related proposals" how it should be done.

EDIT: ok, https://en.wikipedia.org/wiki/Slash_(punctuation)#Spacing confirmed my assumptions: There should only be ' / ' when you want to separate alternatives of multi-word constructs which doesn't apply here. I wanted to write "20/50/100/400" so that people would not confuse it with "Show 20" or "400 previous results" or something like that. Can you accept this?

@coolo
Copy link
Contributor

coolo commented Jun 14, 2016

well, look at our bootstrap table pagination

@okurz
Copy link
Member Author

okurz commented Jun 14, 2016

also I did the "mistake" to record the screenshot at browser zoom of 90%.

Here is the screenshot at 100%:
openqa_limit_previous_results_gui_100percent

@coolo
Copy link
Contributor

coolo commented Jun 14, 2016

Just experimenting: https://jsfiddle.net/gp4b0ywy/

@coolo
Copy link
Contributor

coolo commented Jun 14, 2016

Your wikipedia link is pointless btw as it's very uncommon to click on text. While it's pretty common to have spaces around links to make clicking the wanted option more likely

The query parameter 'limit_previous' allows to show more than the default 10
previous results on demand for some time. The current commit adds web UI
selections below the table of the previous build to reload the same page with
higher number of previous results on demand.
@okurz okurz force-pushed the feature/limit_previous_builds_gui branch from 81a5023 to fbd760e Compare July 7, 2016 04:24
@okurz
Copy link
Member Author

okurz commented Jul 7, 2016

fine, here you go. screenshot in PR description updated

@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.725% when pulling fbd760e on okurz:feature/limit_previous_builds_gui into c34c90b on os-autoinst:master.

@coolo coolo merged commit c1ef788 into os-autoinst:master Jul 7, 2016
@okurz okurz deleted the feature/limit_previous_builds_gui branch November 13, 2018 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants