Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Logging support out of WebAPI #860

Merged
merged 1 commit into from Sep 12, 2016
Merged

Split Logging support out of WebAPI #860

merged 1 commit into from Sep 12, 2016

Conversation

coolo
Copy link
Contributor

@coolo coolo commented Sep 12, 2016

and use it for webapi and scheduler

@coolo coolo force-pushed the make_websockets_log branch 2 times, most recently from 5db68b3 to 016409e Compare September 12, 2016 11:49
@aaannz
Copy link
Contributor

aaannz commented Sep 12, 2016

Nitpick, if you changed (c) in Scheduler.pm, you may update it in IPC.pm as well and add one to db_profiler.pm

@aaannz
Copy link
Contributor

aaannz commented Sep 12, 2016

The rest 👍

@coolo
Copy link
Contributor Author

coolo commented Sep 12, 2016

updated copyrights and removed the pp breaking tests

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 70.577% when pulling 285a1ad on make_websockets_log into bb34ce3 on master.

and use it for webapi and scheduler
@coolo coolo merged commit 7f4a46b into master Sep 12, 2016
@coolo coolo deleted the make_websockets_log branch September 12, 2016 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants