Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test whether job still exists in reduce_result #863

Merged
merged 1 commit into from Sep 16, 2016
Merged

Test whether job still exists in reduce_result #863

merged 1 commit into from Sep 16, 2016

Conversation

Martchus
Copy link
Contributor

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.554% when pulling ed5fa00 on Martchus:fix_reduce_result into c66d62c on os-autoinst:master.

@aaannz
Copy link
Contributor

aaannz commented Sep 12, 2016

Please log it as warning together with at least $args->{jobid}. I don't think we remove old jobs from database, do we @coolo ? Maybe some external factor, like manually cleaning jobs when scheduler ran afoul?

@coolo
Copy link
Contributor

coolo commented Sep 12, 2016

well, we have a DELETE route for /jobs - and it doesn't remove gru_tasks

aaannz
aaannz approved these changes Sep 16, 2016
View reviewed changes
Copy link
Contributor

@aaannz aaannz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created poo#13760 to track DELETE not removing gru tasks.

Thinking about this PR we don't really need job anywhere else than check for important job so I guess missing job is not an issue.

👍

@aaannz aaannz merged commit 9172162 into os-autoinst:master Sep 16, 2016
@Martchus Martchus deleted the fix_reduce_result branch October 11, 2016 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaannz aaannz aaannz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Martchus @coveralls @aaannz @coolo