Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'match' query parameter for index page #879

Merged
merged 2 commits into from Sep 16, 2016

Conversation

okurz
Copy link
Member

@okurz okurz commented Sep 15, 2016

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 70.609% when pulling fa2c138 on okurz:feature/filter_index_page into 67abfeb on os-autoinst:master.

@aaannz
Copy link
Contributor

aaannz commented Sep 15, 2016

I don't understand why 'match' keyword. Somehow I don't feel to like it.
Why not just use group even for matching?

@okurz
Copy link
Member Author

okurz commented Sep 15, 2016

seems like a good idea, I will try

@Martchus
Copy link
Contributor

@aaannz Using the group for matching would make filtering for the particular group opensuse difficult if there are two groups opensuse and opensuse test.

@aaannz
Copy link
Contributor

aaannz commented Sep 16, 2016

I'm aware of that and I'm not sure if it is a big deal. For exact matches is should be possible to add $ at the and of the match :)

From my POV, I would rather have to put $ at the end of the match than extra match query option.

@Martchus
Copy link
Contributor

Ok, that sounds easy enough.

@aaannz aaannz merged commit b38e41e into os-autoinst:master Sep 16, 2016
@okurz okurz deleted the feature/filter_index_page branch September 19, 2016 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants