Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logwarn from openSUSE in CI #45

Merged
merged 3 commits into from May 9, 2023
Merged

Use logwarn from openSUSE in CI #45

merged 3 commits into from May 9, 2023

Conversation

kalikiana
Copy link
Member

@kalikiana kalikiana commented May 8, 2023

That's 1.0.17 at the time of this writing.

See: https://progress.opensuse.org/issues/128591

.travis.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

@Martchus
Copy link
Contributor

Martchus commented May 8, 2023

If you feel very compelled to wrap this code in a Makefile (I personally don't see the point) then just keep it as-is but call the Makefile something different, e.g. Makefile.CI so nobody will invoke it accedentally and with wrong expectations.

@kalikiana
Copy link
Member Author

kalikiana commented May 9, 2023

If you feel very compelled to wrap this code in a Makefile (I personally don't see the point) then just keep it as-is but call the Makefile something different, e.g. Makefile.CI so nobody will invoke it accedentally and with wrong expectations.

The point was exactly to make it easy to install and reproduce the CI setup locally. I guess I'll drop it.

Maybe I can switch CI to OpenSUSE. For Ubuntu there doesn't seem to be a package.

@kalikiana kalikiana changed the title Use the same logwarn via makefile Use the latest logwarn 1.0.17 in CI May 9, 2023
@kalikiana kalikiana marked this pull request as draft May 9, 2023 06:45
@kalikiana kalikiana changed the title Use the latest logwarn 1.0.17 in CI Use logwarn from openSUSE in CI May 9, 2023
@kalikiana kalikiana marked this pull request as ready for review May 9, 2023 07:15
@kalikiana kalikiana marked this pull request as draft May 9, 2023 07:50
@kalikiana kalikiana marked this pull request as ready for review May 9, 2023 07:53
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting .travis.yml is fine but should be in a separate commit

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
By default it's not installed in openSUSE Tumbleweed containers
@okurz okurz merged commit f524205 into master May 9, 2023
5 checks passed
@okurz okurz deleted the logwarn_ver_makef branch May 9, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants