-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use logwarn from openSUSE in CI #45
Conversation
363404b
to
17b9f95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
If you feel very compelled to wrap this code in a Makefile (I personally don't see the point) then just keep it as-is but call the Makefile something different, e.g. |
The point was exactly to make it easy to install and reproduce the CI setup locally. I guess I'll drop it. Maybe I can switch CI to OpenSUSE. For Ubuntu there doesn't seem to be a package. |
17b9f95
to
0de963d
Compare
0de963d
to
4076405
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting .travis.yml is fine but should be in a separate commit
4076405
to
5da94d2
Compare
That's 1.0.17 at the time of this writing. See: https://progress.opensuse.org/issues/128591
5da94d2
to
265ba27
Compare
By default it's not installed in openSUSE Tumbleweed containers
- run: | | ||
PATH=/tmp/logwarn/bin:$PATH prove -v ./test_logwarn | ||
- name: Run unit tests | ||
run: ./test_logwarn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was the prove
removed? test_logwarn
can exit with non-zero here and noone will notice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh because prove is not installed in that container. and the exit code should be noticed.
I was confused because it actually fails on my machine.
That's 1.0.17 at the time of this writing.
See: https://progress.opensuse.org/issues/128591