Add agama staging test #217
Conversation
| <flavor name="ALP" folder="images/x86_64/agama-live:ALP" distri="alp"> | ||
| <hdd filemask="agama-live.*-ALP-Build.*iso$"/> | ||
| </flavor> | ||
| <flavor name="default" folder="images/x86_64/agama-live:default" distri="alp"> |
There was a problem hiding this comment.
the flavor should not be fixed to one architecture, see how it is done in other places:
https://github.com/os-autoinst/openqa-trigger-from-obs/blob/master/xml/obs/SUSE%3AALP%3AMicro.xml#L13
There is some use of /*/
There was a problem hiding this comment.
why the distri="alp" ? actually Agama is not related with ALP exclusively.
There was a problem hiding this comment.
why the
distri="alp"? actually Agama is not related with ALP exclusively.
I just following the distri name of https://openqa.opensuse.org/group_overview/96, so which name you prefer it ?
There was a problem hiding this comment.
doesn't look mandatory, we can omit it I guess.
| project_pattern="systemsmanagement:Agama:Staging" | ||
| dist_path="obspublish-other::openqa/systemsmanagement:Agama:Staging/" | ||
| version="agama-0.9" | ||
| archs="x86_64 aarch64"> |
There was a problem hiding this comment.
we can add the 4 architectures, in some point there will be available.
| dist_path="obspublish-other::openqa/systemsmanagement:Agama:Staging/" | ||
| version="agama-0.9" | ||
| archs="x86_64 aarch64"> | ||
| <flavor name="ALP" folder="images/x86_64/agama-live:ALP" distri="alp"> |
There was a problem hiding this comment.
shouldn't be the flavor names prepended by agama: agama-live:ALP as in OBS to distinguish from other images flavors for other components? for example the cli could have also flavors, https://build.opensuse.org/package/show/systemsmanagement:Agama:Staging/agama-cli
That would help to distinguish them
There was a problem hiding this comment.
shouldn't be the flavor names prepended by agama:
agama-live:ALPas in OBS to distinguish from other images flavors for other components? for example the cli could have also flavors, https://build.opensuse.org/package/show/systemsmanagement:Agama:Staging/agama-cli That would help to distinguish them
I just use flavor of https://openqa.opensuse.org/group_overview/96, so do you mean we need add prefix for every flavor? Such as:
ALP->agama-live:ALP
defaut->agama-live:default
default-Playwright->agama-live:default-Playwright
There was a problem hiding this comment.
yes, but I guess without :, just -, but I'm not sure, we need to look to other examples.
| <openQA | ||
| project_pattern="systemsmanagement:Agama:Staging" | ||
| dist_path="obspublish-other::openqa/systemsmanagement:Agama:Staging/" | ||
| version="agama-0.9" |
There was a problem hiding this comment.
I don't think this could have any meaning for a staging project, but I'm not sure what to use ... I guess this is necessary for openQA to configure the mediums, perhaps, agama-staging would be more correct.
|
Once you address that feedback, would be great to run the scripts generated in the O3 server itself to see that everything works before merging, of course along with creating the mediums/configuration in openQA web ui. |
Do you want create new job group for this staging check or we reuse current job group https://openqa.opensuse.org/group_overview/96? |
I guess we can reuse existing job group, anyway all that was there was frozen and we need to do some hacks and retrigger it manually so now it might become something better, but yes, should be development because in OBS we would be testing latest commits. Maybe we need to call this staging and have a development one in the future, but I don't think it is the case in O3 for now. |
Create new flavor and manual trigger on O3 setup: |
|
@andrii-suse could you please take a look to review? |
|
@jlausuch could you please give some review here? |
|
LGTM, let me know if I need to merge it |
|
It is ready to merge, feel free to skip that CI issue as the author will not be available today to rebase. |
|
sorry for the late reply (I was OoO). LTGM. |
https://progress.opensuse.org/issues/130709