Bump connection timeouts to 60 seconds #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recent connection timeouts show that 10 seconds might be to little. As the script doesn't have strict runtime requirements and big services like e.g. bugzilla can get quite slow I made the reasonable assumption that 60 seconds for a connection is fine. From the commit history I couldn't find a reason why the inital 10 seconds where choosen so I assume this was just a default suggestion of pylint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recent connection timeouts show that 10 seconds might be to little. As the script doesn't have strict runtime requirements and big services like e.g. bugzilla can get quite slow I made the reasonable assumption that 60 seconds for a connection is fine. From the commit history I couldn't find a reason why the inital 10 seconds where choosen so I assume this was just a default suggestion of pylint.