Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2.7 support from CI and tox #140

Merged
merged 2 commits into from Mar 11, 2021
Merged

Conversation

kalikiana
Copy link
Member

@kalikiana kalikiana commented Mar 3, 2021

Fixes poo#89206

Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's basically what I've suggested in the ticket so I'm fine with it.

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be more explicit with dropping python2 support, not just remove it from testing but searching for all relevant references

@Martchus
Copy link
Contributor

Martchus commented Mar 3, 2021

I wanted to write the same but couldn't find any references to Python 2 in the README.

@kalikiana
Copy link
Member Author

The only mentions of it are in the Travis and tox configurations afair

@okurz
Copy link
Member

okurz commented Mar 3, 2021

well, it's a bit hidden but there, e.g.

though all except the first is basically "compatibility code" which doesn't harm, so probably only the first point needs covering

@okurz
Copy link
Member

okurz commented Mar 4, 2021

tests fail now. As suggested in #140 (comment) please only handle the first point

@okurz
Copy link
Member

okurz commented Mar 11, 2021

have you seen my suggestion to only focus on "mentions of pip and package names in https://github.com/os-autoinst/openqa_review/blob/master/README.md#usage , probably need to be python3 variants"?

@kalikiana
Copy link
Member Author

have you seen my suggestion to only focus on "mentions of pip and package names in https://github.com/os-autoinst/openqa_review/blob/master/README.md#usage , probably need to be python3 variants"?

Yes. And I was following your suggestion to drop the FileNotFoundError = IOError bit. But I'm splitting up the changes now and I would suggest to only keep the tox/ci bits and disambiguate documented commands in this PR.

@kalikiana kalikiana requested a review from okurz March 11, 2021 11:16
@okurz okurz merged commit 1ae969b into os-autoinst:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants