New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 2.7 support from CI and tox #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's basically what I've suggested in the ticket so I'm fine with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be more explicit with dropping python2 support, not just remove it from testing but searching for all relevant references
I wanted to write the same but couldn't find any references to Python 2 in the README. |
The only mentions of it are in the Travis and tox configurations afair |
well, it's a bit hidden but there, e.g.
though all except the first is basically "compatibility code" which doesn't harm, so probably only the first point needs covering |
ab8d4ce
to
afbe872
Compare
tests fail now. As suggested in #140 (comment) please only handle the first point |
have you seen my suggestion to only focus on "mentions of pip and package names in https://github.com/os-autoinst/openqa_review/blob/master/README.md#usage , probably need to be python3 variants"? |
Otherwise pip might be pip2 depending on the system.
Yes. And I was following your suggestion to drop the |
Fixes poo#89206