Only decode and return browser content in the successful case #162
Conversation
kalikiana
force-pushed
the
browser_get_content
branch
from
d7dc712
to
0d6fa77
Compare
|
Looks like this is related to #159 |
| return content | ||
| except json.decoder.JSONDecodeError as e: | ||
| msg = "Failed to decode {}: {}".format(r.content, str(e)) | ||
| log.warn(msg) |
There was a problem hiding this comment.
Before we escalate the message with "warning" level I would like to understand what can be the reason for such cases encountered. Should we ignore such issues? Then make it less than "warn". Should we handle such issues? Then "warn" is not high enough.
There was a problem hiding this comment.
I don't know the reason. All i know is that we get invalid JSON, which I'm surfacing here, that the traceback doesn't contain. And I'd consider that an error.
There was a problem hiding this comment.
It would be nice if the URL could be included in the error message.
|
hm, I wonder if the coverage check should not fail here. Could you please check why https://travis-ci.com/github/os-autoinst/openqa_review/jobs/519750936#L214 says 75% and not 100%? We should fail CI checks if the coverage is not ensured to be 100% |
|
I'm closing this since the only case where this was reproduced is one where the HTTP error was not caught. |
See: https://progress.opensuse.org/issues/93943