Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change job groups in todo_only report into section headers #178

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Change job groups in todo_only report into section headers #178

merged 1 commit into from
Sep 13, 2021

Conversation

FruitFly638
Copy link
Contributor

@FruitFly638 FruitFly638 commented Sep 13, 2021 •
edited
Loading

Change job groups from list items to section headings for readability
Corresponding Ticket: https://progress.opensuse.org/issues/97403

perlpunk
perlpunk approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@perlpunk perlpunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test still needs to be adjusted

okurz
okurz reviewed Sep 13, 2021
View reviewed changes
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to describe better the benefit of the change instead of just pointing to the ticket

@FruitFly638
Change job groups in todo_only report into section headers
a36b379 
Change job groups from list items to section headings according to https://progress.opensuse.org/issues/97403
@okurz
Copy link
Member

okurz commented Sep 13, 2021

Very nice!

@okurz okurz merged commit 2e49989 into os-autoinst:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okurz okurz okurz left review comments

@perlpunk perlpunk perlpunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FruitFly638 @okurz @perlpunk