Fix diff-filter parameters in the CI #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillAnastasiadis
changed the title
foursixnine
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI step
Run yamllint for modified job group scheduleswill - correctly - not fail if a file is deleted, since the diff filter used by the previous step to calculate changed files is--diff-filter="*ACMRTUX", which doesn't includeD(Deleted).However, the step will fail (incorrectly, due to the removed file) if there's any other change (like changes in files or added files) that are included in the filter, together with a file removal. That is because of the
*in the filter, which means "if any of the filter parameters match, return all differences".This pr removes the
*filter (select-all-if-any-matches), to avoid getting wrong CI failures for deleted files.