Unify Perl Tidyall #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introducing `tools/tidyall` an improved wrapper over perl's `tidyall`. It does version detection directly in perl and exposes the underlying `tidyall` CLI. - Adds a complementary GitHub Action to run `tools/tidyall` automatically on Pull Requests & Master. - Brings bare minimum dependencies.yaml for running `tools/tidyall`. Adjusted `tools/update-deps` to produce a `cpanfile` alone (without needing an `.spec` file first). - Applied tidy rules. Branched off os-autoinst#30.
Martchus
approved these changes
Dec 14, 2023
kalikiana
reviewed
Dec 14, 2023
| image: perldocker/perl-tester | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - run: GITHUB_ACTIONS=1 ./tools/tidyall --check-only --all --quiet |
There was a problem hiding this comment.
Where is GITHUB_ACTIONS being used? I don't see it anywhere...
There was a problem hiding this comment.
Glad you asked: deep in the source code of tidyall there's a not-so-fully documented usage of this:
okurz
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing
tools/tidyallan improved wrapper over perl'stidyall. It does version detection directly in perl and exposes the underlyingtidyallCLI.Adds a complementary GitHub Action to run
tools/tidyallautomatically on Pull Requests & Master.Brings bare minimum dependencies.yaml for running
tools/tidyall.Adjusted
tools/update-depsto produce acpanfilealone (without needing an.specfile first).Applied tidy rules.
Branched off #30.