Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch nginx log in post fail hook as well #133

Merged
merged 1 commit into from Jul 14, 2023
Merged

Fetch nginx log in post fail hook as well #133

merged 1 commit into from Jul 14, 2023

Conversation

asdil12
Copy link
Member

@asdil12 asdil12 commented Jul 13, 2023

Martchus
Martchus reviewed Jul 13, 2023
View reviewed changes
Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see two changes here:

  • Fetch nginx log in post fail hook as well
  • Test installation with NGINX in CI

So maybe it would make sense to split those into two separate commits.

@asdil12
Copy link
Member Author

asdil12 commented Jul 13, 2023

Adding this other file was unintentional

@asdil12
Copy link
Member Author

asdil12 commented Jul 13, 2023

Failing CI is unrelated, but we are lucky as we can see the post fail hook actually working:
https://openqa.opensuse.org/tests/3426290#step/openqa_webui/16

@mergify mergify bot merged commit 37eda87 into os-autoinst:master Jul 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okurz okurz okurz approved these changes

@Martchus Martchus Martchus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@asdil12 @okurz @Martchus