Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule nginx test in ci #134

Merged
merged 2 commits into from Jul 25, 2023
Merged

Schedule nginx test in ci #134

merged 2 commits into from Jul 25, 2023

Conversation

asdil12
Copy link
Member

@asdil12 asdil12 commented Jul 13, 2023

No description provided.

Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just asking for splitting into multiple commits, not a separate PR. However, this is ok as well.

@okurz
Copy link
Member

okurz commented Jul 14, 2023

I suggest you also manually trigger openQA tests based on that new schedule definition to verify

@asdil12
Copy link
Member Author

asdil12 commented Jul 19, 2023

image

Looks good. Tested on local instance due to the O3 migration being in progress right now.
This (unavailable repos via o3) is also the reason why this job failed later.

product: openqa-*-dev-x86_64
machine: 64bit-2G
settings:
OPENQA_HOST: "http://openqa.opensuse.org"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this setting?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk - I copied the section above which has the same setting.
@baierjan I guess you added that section. Any special reason for this line?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall correctly, the default https protocol failed in some step (maybe due to the weird proxy setup on o3?), this was a workaround recommended by @okurz (https://suse.slack.com/archives/C02AJ1E568M/p1682587547710399?thread_ts=1682587184.320269&cid=C02AJ1E568M)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that proxy setup is over. Let's try without this setting :) @asdil12 can you please remove it in another commit from all mentions in this file

@mergify
Copy link
Contributor

mergify bot commented Jul 22, 2023

This pull request is now in conflicts. Could you fix it? 🙏

@kalikiana
Copy link
Member

kalikiana commented Jul 24, 2023

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Jul 24, 2023

rebase

❌ Base branch update has failed

Git reported the following error:

Rebasing (1/1)
Auto-merging scenario-definitions.yaml
CONFLICT (content): Merge conflict in scenario-definitions.yaml
error: could not apply 95cbb8d... Schedule nginx test in ci
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 95cbb8d... Schedule nginx test in ci

err-code: 002FA

scenario-definitions.yaml Outdated Show resolved Hide resolved
@asdil12 asdil12 merged commit c4a320f into os-autoinst:master Jul 25, 2023
3 of 4 checks passed
@asdil12 asdil12 deleted the nginx2 branch July 25, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants