Handle race condition in gui password #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needle worker-lockscreen-password-prompt-20230725 created/updated and password typed password created, retriggered CI openQA job https://openqa.opensuse.org/tests/3451186 EDIT: https://openqa.opensuse.org/tests/3451193 looks good now |
Explicit needle checks are quicker and also safer than any "sleep-like" calls. This fixes a race condition where the lockscreen is properly handled but the subsequent assert_screen catches too quickly on the still visible password prompt. Related progress issue: https://progress.opensuse.org/issues/133301
okurz
force-pushed
the
feature/lockscreen_race_fix_poo133301
branch
from
8f8e5ba
to
09f8535
Compare
okurz
changed the title
perlpunk
approved these changes
Jul 25, 2023
|
adding "merge-fast" to unblock the OSD deployment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related progress issue: https://progress.opensuse.org/issues/133301