Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change scenario definitions to be usable instead of templates #144

Merged
merged 1 commit into from Aug 10, 2023

Conversation

mimi1vx
Copy link
Member

@mimi1vx mimi1vx commented Aug 9, 2023

scenario-definitions.yaml Outdated Show resolved Hide resolved
@perlpunk
Copy link
Contributor

perlpunk commented Aug 9, 2023

The new scenario would now be run for every pull request, right? do we want that?

scenario-definitions.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@perlpunk perlpunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@mimi1vx
Copy link
Member Author

mimi1vx commented Aug 10, 2023

The new scenario would now be run for every pull request, right? do we want that?

this is a good question :D I think is little overkill on other side it will use almost all code paths in tests so shows almost all possible problems early

Copy link
Member

@kalikiana kalikiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Imho we can look into further splitting later if necessary.

@mimi1vx mimi1vx requested a review from perlpunk August 10, 2023 08:45
@mergify mergify bot merged commit 487ec9c into os-autoinst:master Aug 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants