Fix openqa_install+publish scenario #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It needs machine and product. At least the missing machine will make the next+previous tab not working because `NULL` is passed to postgres. Not sure what effect the missing product has.
perlpunk
force-pushed
the
fix-openqa_install+publish
branch
from
58b7c4c
to
18fde94
Compare
kalikiana
reviewed
Sep 12, 2023
| @@ -39,6 +39,7 @@ job_templates: | |||
| settings: | |||
| OPENQA_WEB_PROXY: 'nginx' | |||
| openqa_install+publish: | |||
| <<: *common | |||
There was a problem hiding this comment.
How did you notice this was broken? https://openqa.opensuse.org/tests/3570245#next_previous looks all green to me
There was a problem hiding this comment.
Ah, I should have added this link: https://openqa.opensuse.org/tests/3570330#next_previous
This only shows one test.
There was a problem hiding this comment.
Do you think we can make the error more prominent in openQA? Overall the test was working quite nicely but the error in openQA is rather subtle, right?
There was a problem hiding this comment.
I would first like to find out why the SQL query didn't work with machine set to NULL, because when I tried it manually in psql, the query returned the expected rows.
okurz
approved these changes
Sep 14, 2023
kalikiana
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It needs machine and product.
At least the missing machine will make the next+previous tab not working because
NULLis passed to postgres.Not sure what effect the missing product has.
See for example this test shows no previous or next tests: https://openqa.opensuse.org/tests/3570330#next_previous
Compared to this openqa_from_git: https://openqa.opensuse.org/tests/3570329#next_previous