[WIP] Replace send_key by send_key_until_needlematch to change to the console #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilausuch
force-pushed
the
fix_change_to_console_of_openqa_webui
branch
from
cefd5f3
to
81fec03
Compare
ilausuch
changed the title
ilausuch
force-pushed
the
fix_change_to_console_of_openqa_webui
branch
from
81fec03
to
07d83f0
Compare
okurz
requested changes
Aug 4, 2021
There was a problem hiding this comment.
Have you seen https://progress.opensuse.org/issues/95721#note-3 ? This mentioned that the hotkey was effective but that the test did not wait long enough. You are doing something quite different. Also in https://progress.opensuse.org/issues/95721#note-10 you provided an example of send_key 'ret' which is again something different
kalikiana
reviewed
Aug 5, 2021
ilausuch
force-pushed
the
fix_change_to_console_of_openqa_webui
branch
from
07d83f0
to
cfe08d7
Compare
ilausuch
force-pushed
the
fix_change_to_console_of_openqa_webui
branch
from
cfe08d7
to
c3bbcb8
Compare
|
this isn't progressing and I guess @ilausuch has no plans to continue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes send_key is not enough to force the change to the console failing
the console needle check.
https://progress.opensuse.org/issues/95721