Use script_retry instead of shell for loops

[kalikiana]

Fixes: https://progress.opensuse.org/issues/110803

[okurz]

First, why should script_retry be better than the bash-internal loop? Second, where should script_retry come from? I think again you are confusing os-autoinst-distri-openQA and os-autoinst-distri-opensuse. In any case I prefer the bash internal loop to prevent unnecessary scope switching between bash within the SUT and perl code on the outside worker environment

[okurz]

Better don't copy-paste the implementation when we have a better approach in the working already, see os-autoinst/os-autoinst#2004

[kalikiana]

I don't understand your comment given your saying the function worse than what we have.

[kalikiana]

First, why should script_retry be better than the bash-internal loop? Second, where should script_retry come from? I think again you are confusing os-autoinst-distri-openQA and os-autoinst-distri-opensuse. In any case I prefer the bash internal loop to prevent unnecessary scope switching between bash within the SUT and perl code on the outside worker environment

It is based on a suggestion by @grisu48 and yes, I realized after pushing the initial branch that this is a function from distri-opensuse. If you think this is a bad approach, maybe it should be re-considered in os-autoinst-distri-opensuse as well?

[okurz]

It is based on a suggestion by @grisu48 and yes, I realized after pushing the initial branch that this is a function from distri-opensuse. If you think this is a bad approach, maybe it should be re-considered in os-autoinst-distri-opensuse as well?

Maybe but I leave it to the maintainers of os-autoinst-distri-opensuse to decide that. For this test distribution here I see no benefit

[Martchus]

In any case I prefer the bash internal loop to prevent unnecessary scope switching between bash within the SUT and perl code on the outside worker environment

That's actually a good point.

I mainly opted for using the helper because it introduces a delay between the attempts (which might otherwise be pointless anyways). However, a delay can also be added on Bash level.

[kalikiana]

Verification run: https://openqa.opensuse.org/tests/2339756

Well, no strong opinion on my side. I figured I'd try what was suggested since it's proven to work well in some cases.

[grisu48]

It is based on a suggestion by @grisu48 and yes, I realized after pushing the initial branch that this is a function from distri-opensuse. If you think this is a bad approach, maybe it should be re-considered in os-autoinst-distri-opensuse as well?

Maybe but I leave it to the maintainers of os-autoinst-distri-opensuse to decide that. For this test distribution here I see no benefit

The reason to not use distri-opensuse-specific functions is very valid, however the main advantage of using script_retry in this was was the delay => 60 parameter. The same could have been achieved by adding a sleep to the loop.

This is just for future reference, no need to change anything now.