Extend documentation for lib/partition_setup.pm #8674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zaoliang
changed the title
asdil12
requested changes
Nov 5, 2019
lib/partition_setup.pm
Outdated
| @@ -209,7 +210,7 @@ sub set_partition_size { | |||
|
|
|||
| resize_partition(); | |||
|
|
|||
| Method assumes that correct disk is already selected | |||
| Method assumes that correct disk is already selected. | |||
There was a problem hiding this comment.
Suggested change
| Method assumes that correct disk is already selected. | |
| Method assumes that correct disk is already selected. |
lib/partition_setup.pm
Outdated
| @@ -396,9 +400,12 @@ sub addlv { | |||
|
|
|||
| =head2 addboot | |||
|
|
|||
| addboot(); | |||
| addboot($part_size, [%default_boot_sizes]); | |||
There was a problem hiding this comment.
Suggested change
| addboot($part_size, [%default_boot_sizes]); | |
| addboot($part_size); |
%default_boot_sizes is not a parameter.
lib/partition_setup.pm
Outdated
|
|
||
| Adds a boot partition, calls C<addpart> for this | ||
| C<$part_size> is the size of partition. | ||
| C<%default_boot_sizes> is pre-defined default boot size. |
There was a problem hiding this comment.
Suggested change
| C<%default_boot_sizes> is pre-defined default boot size. |
There was a problem hiding this comment.
Is this still there?
%default_boot_sizes is not a parameter.
lib/partition_setup.pm
Outdated
|
|
||
| Example: | ||
|
|
||
| take_first_disk iscsi => 1; |
There was a problem hiding this comment.
Suggested change
| take_first_disk iscsi => 1; | |
| take_first_disk(iscsi => 1); |
lib/partition_setup.pm
Outdated
|
|
||
| Selects the first disk in the list to be partitioned | ||
| Take the first disk to be partitioned. Take first storage ng if it is C<is_storage_ng>. |
There was a problem hiding this comment.
Could you rephrase that?
I don't really understand what you want to say in the 2nd sentence.
|
updated now |
asdil12
requested changes
Nov 6, 2019
lib/partition_setup.pm
Outdated
| Deletes all existing partitions in the expert partitioner | ||
| Despite the name it does not check if it is run on a storage ng system | ||
| Deletes all existing partitions in the expert partitioner. | ||
| Despite the name it does not check if it is run on a storage ng system, |
There was a problem hiding this comment.
Suggested change
| Despite the name it does not check if it is run on a storage ng system, | |
| Despite the name it does not check if it is run on a storage ng system, |
lib/partition_setup.pm
Outdated
|
|
||
| Adds a boot partition, calls C<addpart> for this | ||
| C<$part_size> is the size of partition. | ||
| C<%default_boot_sizes> is pre-defined default boot size. |
There was a problem hiding this comment.
Is this still there?
%default_boot_sizes is not a parameter.
asdil12
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://progress.opensuse.org/issues/57917