Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generic-desktop tag from screenlock needles #23

Merged
merged 1 commit into from Dec 5, 2023
Merged

Conversation

baierjan
Copy link
Member

@baierjan baierjan commented Dec 4, 2023

@okurz
Copy link
Member

okurz commented Dec 4, 2023

This looks the same as PR #20 that already tried it and we reverted in #21 due to https://progress.opensuse.org/issues/135143#note-9 . Please take a look and elaborate

@baierjan
Copy link
Member Author

baierjan commented Dec 4, 2023

This looks the same as PR #20 that already tried it and we reverted in #21 due to https://progress.opensuse.org/issues/135143#note-9 . Please take a look and elaborate

That's openqa-desktop, that tag is indeed important. I am removing just the generic-desktop. I did the verification for that as well. Actually, I have a verification for each scenario:

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's try

@okurz okurz merged commit beaf4c6 into master Dec 5, 2023
2 checks passed
@okurz okurz deleted the screenlock_tags branch December 5, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants