-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup installation overview needles #226
Conversation
I need a verification run ;) |
There are 5 runs above, do you really want me to get of them? =) |
But, those are not verification runs, those are examples of the duplicates, aren't they?. 😕 Also, I am seeing on the first example https://openqa.opensuse.org/tests/442300#step/installation_overview/1 that it is matching one needle that is deleted on this PR A verification run would be one which is not matching one of the deleted needles. |
As spoken with @rwx788 |
We have created new needles to verify release notes button on installation settings overview screen. It also matches other newly created needles without button. Hence as a cleanup, we remove them to rely only on needles with release notes button area. This removes identified duplicates, which won't be removed automatically, as both match.
a18e843
to
53d5071
Compare
@rwx788 merged, now please monitor o3 jobs closely. thanks. |
@okurz Will do so. |
this breaks staging. why does this now check for a release notes button anways? if we wanted to verify that release notes work we should have a separate test for that. |
@lnussel My bad, terribly sorry for that. Previously we had good_buttons test which aim was to verify release_notes button as well, but at some point needle without it was created and test became useless. For SLE we test release notes separately, but here as part of improvement we wanted to introduce new needles. Could you please point me to the staging job group you are referring to? |
I've reverted the commit so we can continue |
Note that, for openSUSE, we don't have the release note button in the Staging testdvd. |
Was not aware of it. Then yes, let's keep it as it is after revert and if required, we add separate test for release notes. Thanks! |
We have created new needles to verify release notes button on
installation settings overview screen. It also matches other newly
created needles without button. Hence as a cleanup, we remove them to
rely only on needles with release notes button area. This removes
identified duplicates, which won't be removed automatically, as both
match.
Examples of such duplicate needles:
https://openqa.opensuse.org/tests/442300#step/installation_overview/1
https://openqa.opensuse.org/tests/442307#step/installation_overview/1
https://openqa.opensuse.org/tests/442301#step/installation_overview/1
https://openqa.opensuse.org/tests/442305#step/installation_overview/1
https://openqa.opensuse.org/tests/442253#step/installation_overview/1