Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup installation overview needles #226

Merged
merged 1 commit into from
Jul 11, 2017

Conversation

rwx788
Copy link
Member

@rwx788 rwx788 commented Jul 7, 2017

We have created new needles to verify release notes button on
installation settings overview screen. It also matches other newly
created needles without button. Hence as a cleanup, we remove them to
rely only on needles with release notes button area. This removes
identified duplicates, which won't be removed automatically, as both
match.

Examples of such duplicate needles:
https://openqa.opensuse.org/tests/442300#step/installation_overview/1
https://openqa.opensuse.org/tests/442307#step/installation_overview/1
https://openqa.opensuse.org/tests/442301#step/installation_overview/1
https://openqa.opensuse.org/tests/442305#step/installation_overview/1
https://openqa.opensuse.org/tests/442253#step/installation_overview/1

@SergioAtSUSE
Copy link
Member

I need a verification run ;)

@rwx788
Copy link
Member Author

rwx788 commented Jul 7, 2017

There are 5 runs above, do you really want me to get of them? =)

@SergioAtSUSE
Copy link
Member

SergioAtSUSE commented Jul 7, 2017

But, those are not verification runs, those are examples of the duplicates, aren't they?. 😕

Also, I am seeing on the first example https://openqa.opensuse.org/tests/442300#step/installation_overview/1 that it is matching one needle that is deleted on this PR inst-overview-textmode-20160831.

A verification run would be one which is not matching one of the deleted needles.
And also I expect the verification run to not be on openqa.opensuse.org, since this might mean that the changes are already on productive instances.

@SergioAtSUSE
Copy link
Member

SergioAtSUSE commented Jul 7, 2017

As spoken with @rwx788
We will wait for tomorrow for that PR to also removed the next duplicates.

@SergioAtSUSE SergioAtSUSE changed the title Cleanup installation overview needles [WIP] Cleanup installation overview needles Jul 7, 2017
We have created new needles to verify release notes button on
installation settings overview screen. It also matches other newly
created needles without button. Hence as a cleanup, we remove them to
rely only on needles with release notes button area. This removes
identified duplicates, which won't be removed automatically, as both
match.
@rwx788 rwx788 changed the title [WIP] Cleanup installation overview needles Cleanup installation overview needles Jul 10, 2017
@okurz okurz merged commit aab646a into os-autoinst:master Jul 11, 2017
@okurz
Copy link
Member

okurz commented Jul 11, 2017

@rwx788 merged, now please monitor o3 jobs closely. thanks.

@rwx788
Copy link
Member Author

rwx788 commented Jul 11, 2017

@okurz Will do so.

@lnussel
Copy link
Contributor

lnussel commented Jul 12, 2017

this breaks staging.

why does this now check for a release notes button anways? if we wanted to verify that release notes work we should have a separate test for that.

@rwx788
Copy link
Member Author

rwx788 commented Jul 12, 2017

@lnussel My bad, terribly sorry for that. Previously we had good_buttons test which aim was to verify release_notes button as well, but at some point needle without it was created and test became useless. For SLE we test release notes separately, but here as part of improvement we wanted to introduce new needles. Could you please point me to the staging job group you are referring to?

@lnussel
Copy link
Contributor

lnussel commented Jul 12, 2017

@lnussel
Copy link
Contributor

lnussel commented Jul 12, 2017

I've reverted the commit so we can continue

@nilxam
Copy link
Member

nilxam commented Jul 12, 2017

Note that, for openSUSE, we don't have the release note button in the Staging testdvd.

@rwx788
Copy link
Member Author

rwx788 commented Jul 12, 2017

Was not aware of it. Then yes, let's keep it as it is after revert and if required, we add separate test for release notes. Thanks!

@rwx788 rwx788 deleted the 20042_release_notes branch May 9, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants