Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add texmode testsuite for ext3,xfs and btrfs #381

Merged

Conversation

jknphy
Copy link
Contributor

@jknphy jknphy commented Jun 4, 2018

@SergioAtSUSE
Copy link
Member

I think you should make it clearer in the comment that FILESYSTEM=ext3, FILESYSTEM=xfs, FILESYSTEM=btrfs. And, it should be better if we test ext4 instead of ext3.

Copy link
Member

@SergioAtSUSE SergioAtSUSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jknphy
Copy link
Contributor Author

jknphy commented Jun 4, 2018

ext4 is already tested for TW.

@SergioAtSUSE
Copy link
Member

Not on textmode installation: https://openqa.opensuse.org/tests/686325#step/welcome/1

@jknphy jknphy changed the title [WIP] Add texmode testsuite for ext3,xfs and btrfs Add texmode testsuite for ext3,xfs and btrfs Jun 4, 2018
@jknphy jknphy changed the title Add texmode testsuite for ext3,xfs and btrfs [WIP] Add texmode testsuite for ext3,xfs and btrfs Jun 4, 2018
@jknphy jknphy force-pushed the create_textmode_partitioning branch from e45c15d to f5e27ae Compare June 4, 2018 13:35
@jknphy
Copy link
Contributor Author

jknphy commented Jun 4, 2018

All verification provided except for ppc. My openQA version is too updated comparing with the one in the ppc worker. Could you please @SergioAtSUSE run it for me? With that I think we have reached good test coverage. I used to clone it:
clone_job.pl --skip-chained-deps --from https://openqa.opensuse.org 685123 FILESYSTEM=ext4 TEST=ext4 INSTALLONLY=1

@jknphy jknphy changed the title [WIP] Add texmode testsuite for ext3,xfs and btrfs Add texmode testsuite for ext3,xfs and btrfs Jun 4, 2018
@SergioAtSUSE
Copy link
Member

I also have problems creating a verification run.
Since this PR only contains new needles and cannot break anything, I am merging it.

Please, create a new PR with ppc64le needles.

@SergioAtSUSE SergioAtSUSE merged commit 61492b0 into os-autoinst:master Jun 4, 2018
@jknphy jknphy deleted the create_textmode_partitioning branch September 7, 2018 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants