Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add needles for awesome test #55

Merged
merged 1 commit into from Jan 25, 2016
Merged

Add needles for awesome test #55

merged 1 commit into from Jan 25, 2016

Conversation

asdil12
Copy link
Member

@asdil12 asdil12 commented Jan 22, 2016

@coolo
Copy link
Contributor

coolo commented Jan 25, 2016

No need to obsolete PRs, they follow your branch

@coolo
Copy link
Contributor

coolo commented Jan 25, 2016

what's missing now is unregistering the needles these needles for minimalx. Actually it would be an idea to leave minimalx needles for DESKTOP=awesome.

@coolo
Copy link
Contributor

coolo commented Jan 25, 2016

this way you avoid needling everything twice

@okurz
Copy link
Member

okurz commented Jan 25, 2016

PR #53 was mine so I think @asdil12 has to create a new one unless we use a common feature branch on the main repo itself which we overwrite.
Regarding the unregistering there might be a problem with the DESKTOP variable being reused ?!?

@coolo
Copy link
Contributor

coolo commented Jan 25, 2016

I didn't say it's easy - but it's worthwhile

@asdil12
Copy link
Member Author

asdil12 commented Jan 25, 2016

Reusing minimalx needles for

  • inst_overview
  • displaymanager

coolo added a commit that referenced this pull request Jan 25, 2016
Add needles for awesome test
@coolo coolo merged commit 8cb69ef into os-autoinst:master Jan 25, 2016
@asdil12 asdil12 deleted the awesome2 branch January 29, 2016 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants