New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests against mocked test API #5
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5 +/- ##
============================================
+ Coverage 22.22% 100.00% +77.77%
============================================
Files 2 5 +3
Lines 18 53 +35
============================================
+ Hits 4 53 +49
+ Misses 14 0 -14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* Add mocked test API and basetest packages * Add substitute modules (instead of using `Test::MockModule`) because this way we don't have to depend on the original test API modules at all * Fix an error in the signature of `start_gui_program` which would prevent tests from passing * See https://progress.opensuse.org/issues/115022
Looks like we're at 100 % test coverage. I've also set the target accordingly. The target for the patch coverage is inherited from the project target and will apparently only be shown updated after the PR has been merged. Note that these tests only show whether the logic within the wheel itself is correct, not that the test API is used correctly or would behave correctly (as the test API is mocked). Not sure whether the existing test that schedules the test module via isotovideo brings much additional value anymore (as it supposedly wouldn't catch any more problems as the unit tests would do). However, we can leave that test in as a springboard for better integration tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrmmm neat way to check what was called
Test::MockModule
) becausethis way we don't have to depend on the original test API modules at
all
start_gui_program
which would preventtests from passing