Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qemu: Prevent serial logs from being truncated on revert #1002

Merged
merged 1 commit into from Aug 3, 2018

Conversation

richiejp
Copy link
Contributor

QEMU overwrites the serial file by default. Because we now restart QEMU during
revert to snapshot, this results in the serial file being truncated. However
we can make use of the logfile and logappend chardev options to overcome this.

Verification run: http://10.160.67.78/tests/641

This is low priority.

QEMU overwrites the serial file by default. Because we now restart QEMU during
revert to snapshot, this results in the serial file being truncated. However
we can make use of the logfile and logappend chardev options to overcome this.
@codecov
Copy link

codecov bot commented Jul 31, 2018

Codecov Report

Merging #1002 into master will increase coverage by 0.1%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1002     +/-   ##
=========================================
+ Coverage   40.27%   40.37%   +0.1%     
=========================================
  Files          34       34             
  Lines        4554     4555      +1     
  Branches      786      786             
=========================================
+ Hits         1834     1839      +5     
+ Misses       2388     2381      -7     
- Partials      332      335      +3
Impacted Files Coverage Δ
backend/qemu.pm 31.14% <75%> (+0.12%) ⬆️
isotovideo 60.98% <0%> (+1.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a980161...aa7f2c4. Read the comment docs.

@foursixnine foursixnine merged commit 8ab2168 into os-autoinst:master Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants