Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: Reset VNC and serial console on snapshot revert #1095

Merged

Conversation

mnowaksuse
Copy link

@mnowaksuse mnowaksuse commented Jan 31, 2019

https://trello.com/c/BbvRHrrw/347-p2-snapshot-revert-leads-to-broken-keyboard-and-or-serial-console-on-vmware

Fails here: http://nilgiri.suse.cz/tests/100#step/keymap_or_locale/4

Reset VNC and serial console on snapshot revert.

On VMware VNC screen and serial console need to be reset on snapshot
revert otherwise both are stalled.

Validation run: http://nilgiri.suse.cz/tests/282

[2019-02-11T10:23:46.225 CET] [debug] LOAD snapshot lastgood to openQA-SUT-42, return code=0
[2019-02-11T10:23:46.226 CET] [debug] A: autotest::selected_console=<log-console>
[2019-02-11T10:23:46.226 CET] [debug] <<< testapi::select_console(testapi_console='sut')
[2019-02-11T10:23:46.252 CET] [debug] B: autotest::selected_console=<sut>

load_snapshot now does not return anything as no one was checking it anyway.

backend/svirt.pm Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 31, 2019

Codecov Report

Merging #1095 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1095      +/-   ##
==========================================
+ Coverage   40.21%   40.25%   +0.04%     
==========================================
  Files          40       40              
  Lines        4794     4794              
  Branches      804      804              
==========================================
+ Hits         1928     1930       +2     
+ Misses       2539     2536       -3     
- Partials      327      328       +1
Impacted Files Coverage Δ
backend/qemu.pm 32.58% <0%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a27d1d2...a9b28ff. Read the comment docs.

mnowaksuse pushed a commit to mnowaksuse/os-autoinst that referenced this pull request Feb 5, 2019
Snapshots on VMware are unreliable. Until
os-autoinst/pull/1095 is ready, they shoul be off.
mnowaksuse pushed a commit to mnowaksuse/os-autoinst that referenced this pull request Feb 5, 2019
Snapshots on VMware are unreliable. Until
os-autoinst/pull/1095 is ready, they should be off.
Michal Nowak added 3 commits February 11, 2019 12:16
https://trello.com/c/BbvRHrrw/347-p2-snapshot-revert-leads-to-broken-keyboard-and-or-serial-console-on-vmware

Fails here: http://nilgiri.suse.cz/tests/100#step/keymap_or_locale/4

Reset VNC and serial console on snapshot revert.

On VMware VNC screen and serial console need to be reset on snapshot
revert otherwise both are stalled.

Validation run: http://nilgiri.suse.cz/tests/282

``
[2019-02-11T10:23:46.225 CET] [debug] LOAD snapshot lastgood to openQA-SUT-42, return code=0
[2019-02-11T10:23:46.226 CET] [debug] A: autotest::selected_console=<log-console>
[2019-02-11T10:23:46.226 CET] [debug] <<< testapi::select_console(testapi_console='sut')
[2019-02-11T10:23:46.252 CET] [debug] B: autotest::selected_console=<sut>
```
@mnowaksuse
Copy link
Author

Comments on this iteration?

Copy link
Member

@foursixnine foursixnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but that possible unwanted undefined variable would be a bit annoying in the logs :)

backend/svirt.pm Show resolved Hide resolved
@foursixnine foursixnine merged commit 726ff93 into os-autoinst:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants