-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VMware: Reset VNC and serial console on snapshot revert #1095
VMware: Reset VNC and serial console on snapshot revert #1095
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1095 +/- ##
==========================================
+ Coverage 40.21% 40.25% +0.04%
==========================================
Files 40 40
Lines 4794 4794
Branches 804 804
==========================================
+ Hits 1928 1930 +2
+ Misses 2539 2536 -3
- Partials 327 328 +1
Continue to review full report at Codecov.
|
Snapshots on VMware are unreliable. Until os-autoinst/pull/1095 is ready, they shoul be off.
Snapshots on VMware are unreliable. Until os-autoinst/pull/1095 is ready, they should be off.
https://trello.com/c/BbvRHrrw/347-p2-snapshot-revert-leads-to-broken-keyboard-and-or-serial-console-on-vmware Fails here: http://nilgiri.suse.cz/tests/100#step/keymap_or_locale/4 Reset VNC and serial console on snapshot revert. On VMware VNC screen and serial console need to be reset on snapshot revert otherwise both are stalled. Validation run: http://nilgiri.suse.cz/tests/282 `` [2019-02-11T10:23:46.225 CET] [debug] LOAD snapshot lastgood to openQA-SUT-42, return code=0 [2019-02-11T10:23:46.226 CET] [debug] A: autotest::selected_console=<log-console> [2019-02-11T10:23:46.226 CET] [debug] <<< testapi::select_console(testapi_console='sut') [2019-02-11T10:23:46.252 CET] [debug] B: autotest::selected_console=<sut> ```
0f4fc38
to
a9b28ff
Compare
Comments on this iteration? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but that possible unwanted undefined variable would be a bit annoying in the logs :)
https://trello.com/c/BbvRHrrw/347-p2-snapshot-revert-leads-to-broken-keyboard-and-or-serial-console-on-vmware
Fails here: http://nilgiri.suse.cz/tests/100#step/keymap_or_locale/4
Reset VNC and serial console on snapshot revert.
On VMware VNC screen and serial console need to be reset on snapshot
revert otherwise both are stalled.
Validation run: http://nilgiri.suse.cz/tests/282
load_snapshot
now does not return anything as no one was checking it anyway.