Silence complain about undefined $libvirt_connector #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martchus
reviewed
Feb 6, 2019
Correct, other backends using virsh will still work |
Martchus
approved these changes
Feb 6, 2019
okurz
reviewed
Feb 7, 2019
backend/svirt.pm
Outdated
| @@ -145,7 +145,7 @@ sub is_shutdown { | |||
| $rsp = $self->run_cmd("powershell -Command \"if (\$(Get-VM -VMName $vmname \| Where-Object {\$_.state -eq 'Off'})) { exit 1 } else { exit 0 }\""); | |||
| } | |||
| else { | |||
| my $libvirt_connector = get_var('VMWARE_REMOTE_VMM'); | |||
| my $libvirt_connector = get_var('VMWARE_REMOTE_VMM') || ''; | |||
There was a problem hiding this comment.
When already using testapi methods I suggest to use them also here to handle the value feedback, so
get_var('too', '')
foursixnine
force-pushed
the
silence-of-the-lambs
branch
from
f88ceee
to
7470d48
Compare
foursixnine
force-pushed
the
silence-of-the-lambs
branch
from
7470d48
to
bd1b27c
Compare
|
We've just discussed with @mnowaksuse, that it'll be better to refactor consoles/sshVirtsh.pm ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.