Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare wait_screen_change earlier #1140

Closed
wants to merge 1 commit into from

Conversation

foursixnine
Copy link
Member

When ::wait_screen_change it is translated internally to
&main::wait_screen_change which means that the symbol will be looked
into the current program instead of the proper library where the method
is defined

@rwx788
Copy link
Member

rwx788 commented Apr 8, 2019

#689

Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foursixnine foursixnine changed the title Decalre wait_screen_change earlier Declare wait_screen_change earlier Apr 8, 2019
When ::wait_screen_change it is translated internally to
&main::wait_screen_change which means that the symbol will be looked
into the current program instead of the proper library where the method
is defined
@rwx788
Copy link
Member

rwx788 commented Apr 8, 2019

Hmm, I wonder if your change could actually break all the tests (doubt that). Could you please restart them?

@foursixnine
Copy link
Member Author

@rwx788 Actually it's my change that breaks all tests :) I guess a bit of reading is in order...
Quickly updating the prototype of the function results in:

Press ENTER or type command to continue
03-testapi.t .. Type of arg 1 to testapi::wait_screen_change must be block or sub {} (not array dereference) at ../testapi.pm line 604, near "@_) "
Bareword "is_serial_terminal" not allowed while "strict subs" in use at ../testapi.pm line 827.
Type of arg 1 to testapi::wait_screen_change must be block or sub {} (not reference constructor) at ../testapi.pm line 1214, near "};"
Bareword "is_serial_terminal" not allowed while "strict subs" in use at ../testapi.pm line 1265.
Type of arg 1 to testapi::wait_screen_change must be block or sub {} (not reference constructor) at ../testapi.pm line 1282, near "};"
Compilation failed in require at 03-testapi.t line 98.
BEGIN failed--compilation aborted at 03-testapi.t line 98.
03-testapi.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 

@rwx788
Copy link
Member

rwx788 commented Apr 8, 2019

So it's even more broken =)))

@foursixnine
Copy link
Member Author

Closing in favor of #1142

@foursixnine foursixnine closed this Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants