Test enhancements #1168
Merged
Test enhancements #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
okurz
commented
Jun 17, 2019
okurz
commented
- t: Catch output of failing runcmd to potentially even adress sporadic failures
- osutils: Let the "attempts" sound less harmful
- t: Do not waste time waiting in test 13-osutils.t
- t: Fix all uncaught output and warnings in 08-autotest.t
- t: Fix warning about undefined variable in 17-basetest.t
Every openQA job had a warn-call about "attempts" without further context as a warning. We can alarm the readers a little bit less :)
It is good to catch all output and strip away alarming "expected errors". Related progress issue: https://progress.opensuse.org/issues/52652
okurz
force-pushed
the
fix/run_cmd_connection_loss
branch
from
c99a5bd
to
d6f7384
Compare
Codecov Report
@@ Coverage Diff @@
## master #1168 +/- ##
===========================================
- Coverage 39.97% 27.41% -12.57%
===========================================
Files 40 40
Lines 4865 4866 +1
Branches 827 827
===========================================
- Hits 1945 1334 -611
- Misses 2586 3314 +728
+ Partials 334 218 -116
Continue to review full report at Codecov.
|
Martchus
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.