Fix broken condition introduced by #1213 #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolo
reviewed
Sep 26, 2019
consoles/sshVirtsh.pm
Outdated
| if ($stderr =~ /lock/i) { | ||
| die "Too many attempts to format HDD" unless (--$bucket); |
There was a problem hiding this comment.
sorry but Pre-increment operator in negated post-if operator is a bit too much obfusciation for me.
There was a problem hiding this comment.
I personally liked it (except for the useless brackets).
|
verification run? |
See the description |
foursixnine
force-pushed
the
oopsibrokeitagain
branch
2 times, most recently
from
250cdbc
to
5822119
Compare
coolo
reviewed
Sep 26, 2019
consoles/sshVirtsh.pm
Outdated
| if ($stderr =~ /lock/i) { | ||
| $bucket--; | ||
| die "Too many attempts to format HDD" unless ($bucket); #Only die when there are no attempts left |
There was a problem hiding this comment.
that comment is a little too obvious and we don't use () if it's a simple statement
Backend should only die when all of the attempts have finished and still the command is not successful.
foursixnine
force-pushed
the
oopsibrokeitagain
branch
from
5822119
to
5ce52d2
Compare
foursixnine
commented
Sep 26, 2019
okurz
approved these changes
Sep 26, 2019
coolo
approved these changes
Sep 26, 2019
Martchus
approved these changes
Sep 26, 2019
|
Travis failure seems unrelated... <.< |
|
I agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FiBackend should only die when all of the attempts have finished and still
the command is not successful.
This should solve the broken xen and zkvm jobs :)
Tested defining manually the domain using the same resource image, and triggering the jobs.