Revert "Allow loading needles from pool directory" to fix loading time regression #1224
Conversation
|
this is purely based on guess work, right? |
| # - Otherwise, the needle will be looked up under $bmwqemu::vars{PRJDIR}. | ||
| my @lookup_dirs; | ||
| my $needles_dir = $bmwqemu::vars{NEEDLES_DIR}; | ||
| push(@lookup_dirs, $needles_dir) if (defined $needles_dir && index($needles_dir, cwd) == 0); |
There was a problem hiding this comment.
this cwd call is what kills us. The whole if is pointless due to:
isotovideo:$bmwqemu::vars{NEEDLES_DIR} //= "$bmwqemu::vars{PRODUCTDIR}/needles";
As such we should move this cwd there. If NEEDLES_DIR is set but doesn't point to cwd, overwrite it.
There was a problem hiding this comment.
makes sense, I'll test this tomorrow
There was a problem hiding this comment.
When I move the check to that assignment one can re-assign that variable later to sneak out from the working directory and load needles from everywhere. (With cwd this wasn't possible changing the working directory within autotest would not affect the backend.)
So I should do that check likely in needle::init where we also check that the needle directory exists. Then cwd would only be executed once per reload.
There was a problem hiding this comment.
sounds useful. I was already surprised by that inefficiency when we looked at the code together yesterday :)
@coolo no, bisected and tested with crosscheck, see |
Reverts #1217 to fix https://progress.opensuse.org/issues/57962