Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tianocore boot menu is shown for aarch64 workaround #1334

Merged
merged 1 commit into from Jan 8, 2020

Conversation

okurz
Copy link
Member

@okurz okurz commented Jan 8, 2020

#1275 removed the boot
menu by default to save 5s of boot time when the menu is not really
required. With the variable BOOT_MENU we can always request the menu
when it is necessary. On aarch64 to boot a non-default disk the
tianocore menu is required so for convience we can propose a different
default value to show the boot menu unless requested differently.

Related progress issue: https://progress.opensuse.org/issues/61910

os-autoinst#1275 removed the boot
menu by default to save 5s of boot time when the menu is not really
required. With the variable BOOT_MENU we can always request the menu
when it is necessary. On aarch64 to boot a non-default disk the
tianocore menu is required so for convience we can propose a different
default value to show the boot menu unless requested differently.

Related progress issue: https://progress.opensuse.org/issues/61910
@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #1334 into master will decrease coverage by 3.77%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1334      +/-   ##
==========================================
- Coverage   56.47%   52.69%   -3.78%     
==========================================
  Files          52       52              
  Lines        6130     6131       +1     
  Branches     1060     1061       +1     
==========================================
- Hits         3462     3231     -231     
- Misses       2255     2512     +257     
+ Partials      413      388      -25
Impacted Files Coverage Δ
backend/qemu.pm 34.74% <0%> (-1.42%) ⬇️
backend/baseclass.pm 45.81% <0%> (-21.3%) ⬇️
consoles/vnc_base.pm 28.28% <0%> (-16.17%) ⬇️
consoles/sshIucvconn.pm 20% <0%> (-16%) ⬇️
consoles/VNC.pm 33.69% <0%> (-9.57%) ⬇️
consoles/network_console.pm 83.33% <0%> (-8.34%) ⬇️
consoles/console.pm 71.73% <0%> (-4.35%) ⬇️
OpenQA/Qemu/Proc.pm 66.83% <0%> (-3.07%) ⬇️
needle.pm 72.82% <0%> (-1.64%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d693abe...522496d. Read the comment docs.

@okurz okurz merged commit ba21858 into os-autoinst:master Jan 8, 2020
@okurz okurz deleted the fix/boot_menu_aarch64 branch January 8, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants